refactor: Integrate @ui5/fs into the monorepo#1126
Merged
Conversation
…5-fs#501) Bumps eslint-plugin-jsdoc from 41.1.2 to 43.1.1. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Florian Vogt <florian.vogt@sap.com>
Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 43.2.0 to 44.2.3. - [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases) - [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc) - [Commits](gajus/eslint-plugin-jsdoc@v43.2.0...v44.2.3) --- updated-dependencies: - dependency-name: eslint-plugin-jsdoc dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Fixes: #826 Test cases: SAP/ui5-project#609 --------- Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com>
Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 44.2.7 to 46.2.2. - [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases) - [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc) - [Commits](gajus/eslint-plugin-jsdoc@v44.2.7...v46.2.2) --- updated-dependencies: - dependency-name: eslint-plugin-jsdoc dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 2.1.2 to 2.2.0. - [Release notes](https://github.com/coverallsapp/github-action/releases) - [Commits](coverallsapp/github-action@v2.1.2...v2.2.0) --- updated-dependencies: - dependency-name: coverallsapp/github-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3.6.0...v3.7.0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
AVA's nodeArguments option doesn't seem to work with loaders on Node 20. Using the NODE_OPTIONS environment variable is however working properly. This unfortunately makes the scripts more verbose but it finally allows testing on Node 20. JIRA: CPOUI5FOUNDATION-612
JIRA: CPOUI5FOUNDATION-612
This reverts commit e7b7c450bc8995f7757c5f6b65a74cbb2f5ad921.
This also solves the Node 20 issue initially addressed via SAP/ui5-fs#511. However, it also addresses another issue that mainly appears in the ui5-builder projects, see SAP/ui5-builder#921. Tests may run a bit slower, but more stable. JIRA: CPOUI5FOUNDATION-612
Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 2.2.0 to 2.2.1. - [Release notes](https://github.com/coverallsapp/github-action/releases) - [Commits](coverallsapp/github-action@v2.2.0...v2.2.1) --- updated-dependencies: - dependency-name: coverallsapp/github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [fsfe/reuse-action](https://github.com/fsfe/reuse-action) from 1 to 2. - [Release notes](https://github.com/fsfe/reuse-action/releases) - [Commits](fsfe/reuse-action@v1...v2) --- updated-dependencies: - dependency-name: fsfe/reuse-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
JIRA: CPOUI5FOUNDATION-1098
JIRA: CPOUI5FOUNDATION-975
matz3
approved these changes
Sep 26, 2025
matz3
requested changes
Sep 26, 2025
Member
matz3
left a comment
matz3
left a comment
There was a problem hiding this comment.
It looks like the previously removed squash commit from logger is part of this PR.
Is it possible to remove it?
Member
Author
After merging the logger, GitHub forced a rebase with the main branch and I did it via GH's button. Please take a look at the commit, it's clean |
Member
|
The commit is not part of the |
d3xter666
force-pushed
the
integrate-ui5-fs
branch
2 times, most recently
from
9b8815e to
1d0ee57
Compare
|
|
Member
Author
|
I needed to rebase on top of the main branch. Now should be better |
d3xter666
force-pushed
the
integrate-ui5-fs
branch
from
1d0ee57 to
a6d0e09
Compare
matz3
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-975